Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace import of collections.Sequence with collections.abc.Sequence #1166

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Replace import of collections.Sequence with collections.abc.Sequence #1166

merged 2 commits into from
Jul 1, 2023

Conversation

oliverholworthy
Copy link
Member

Fixes the following error in Python 3.10 environment

AttributeError: module 'collections' has no attribute 'Sequence'

Replace import of collections.Sequence with collections.abc.Sequence

This was deprecated in Python 3.7 and moved in Python 3.10

@oliverholworthy oliverholworthy added the bug Something isn't working label Jun 30, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.07 milestone Jun 30, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 30, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1166

@edknv edknv merged commit 25f98f1 into NVIDIA-Merlin:main Jul 1, 2023
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edknv edknv edknv approved these changes

Assignees

@oliverholworthy oliverholworthy

Labels
bug Something isn't working
Projects
None yet
Milestone
Merlin 23.07
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverholworthy @edknv